Fix issue_400 terminal propagation and stabilize issue tests#7
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses multiple “issue_*” regressions and hardens runtime behavior in Boost.SML, focusing on correct terminal-state propagation for nested sub-state-machines and improving test stability across differing CTest working directories.
Changes:
- Propagate sub-state-machine termination to matching parent transitions for the same event (issue_400).
- Add bounds checking to dispatch table indexing to avoid out-of-range UB (issue_174 path).
- Stabilize/adjust filesystem-dependent issue tests and reduce analyzer-related flakiness in CI.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
include/boost/sml.hpp |
Implements termination propagation logic and makes is_terminated() SFINAE-safe when no terminate state exists. |
include/boost/sml/utility/dispatch_table.hpp |
Adds range checks around dispatch table indexing. |
test/ft/issues_test.cpp |
Updates issue tests for stable paths, adjusts expectations for fixed behaviors, and adds analyzer guard for a false positive. |
scripts/quality_gates.sh |
Adds Clang-only warning suppressions to avoid specific warnings failing -Werror gates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation