Skip to content

Add StateValue @remarks#4374

Closed
audionerd wants to merge 1 commit into
statelyai:nextfrom
audionerd:add-state-value-remarks
Closed

Add StateValue @remarks#4374
audionerd wants to merge 1 commit into
statelyai:nextfrom
audionerd:add-state-value-remarks

Conversation

@audionerd

Copy link
Copy Markdown
Contributor

this fixes an error when generating API documentation which prevents an documentation index page from being created

this fixes an error when generating API documentation which prevents an documentation index page from being created
@changeset-bot

changeset-bot Bot commented Oct 19, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 53ee34e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 53ee34e:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

/**
* The string or object representing the state value relative to the parent state node.
*
* @remarks

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this whole JSDoc be rewritten somehow? @remarks seems to be somewhat non-standard so, for example, the IDE doesn't really understand it and displays @remarks verbatim

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, this is related to a PR I’m working on to generate XState API docs for the Stately site using API Extractor.

API Extractor expects TSDoc, and I realize now that @remarks happens to be something only TSDoc has:

https://api-extractor.com/pages/tsdoc/tag_remarks

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so I think that perhaps there is something here that specifically breaks the API generation, like this markdown list (but maybe that's not it). So perhaps by rewriting this, by avoiding the problematic pattern - we wouldn't have to introduce non-standard @remarks

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should be possible to re-write this comment to be JSDoc compatible, and still ensure the Markdown generated by API Extractor can be rendered without error by Docusaurus. I’ll take a look.

Also this will make more sense once I have the API docs PR up for review.

@Andarist

Copy link
Copy Markdown
Collaborator

I'm closing this one as superseded by #4391

@Andarist Andarist closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants