Skip to content

Implement temperature tracking and temporary limit calculation#97

Open
ErkkoI wants to merge 8 commits into
statnett:mainfrom
ErkkoI:transient_calculation
Open

Implement temperature tracking and temporary limit calculation#97
ErkkoI wants to merge 8 commits into
statnett:mainfrom
ErkkoI:transient_calculation

Conversation

@ErkkoI
Copy link
Copy Markdown
Contributor

@ErkkoI ErkkoI commented Mar 10, 2026

Implemented heat capacity calculation, final temperature calculation and temporary limit calculation based on final temperature calculation.
Added tests for the CIGRE 601 examples.
Changed vectorization test to handle the additional possible dimensions.

DavidSAmundsen
DavidSAmundsen requested changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@DavidSAmundsen DavidSAmundsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating this PR with a useful addition of transient calculations to the library. We would like to get your changes into the main codebase, but we added some comments on things we would like to be changed or improved.

I have run the tests, and they all pass, but the tests added in this PR produce warnings such as invalid value encountered in divide and invalid value encountered in scalar multiply. This should be fixed.

Comment thread linerate/models/cigre601.py Outdated
Comment thread linerate/models/thermal_model.py Outdated
Comment thread linerate/models/thermal_model.py Outdated
Comment thread linerate/models/thermal_model.py Outdated
Comment thread linerate/models/thermal_model.py Outdated
Comment thread linerate/solver.py Outdated
Comment thread linerate/types.py Outdated
Comment thread tests/integration_tests/test_vectorization.py
Comment thread tests/integration_tests/test_vectorization.py Outdated
Comment thread linerate/types.py
ErkkoI added 2 commits May 10, 2026 13:18
@ErkkoI
Addressed comments
51eff47 
- Added docstrings
- Added some type information
- Made ConductorWithTransientData to a proper type
@ErkkoI
Added .* to pytest configuration parameter norecursedirs to fix hypot…
0fb50e9 
…hesis warning
@ErkkoI
Copy link
Copy Markdown
Contributor Author

ErkkoI commented May 10, 2026

Hi!
Thanks for your comments. I have addressed them and I think especially the class inheritance was good guidance.
The tests also pass with only one warning UserWarning: no explicit representation of timezones available for np.datetime64 which is in older code now that I applied some sensible values to the transient data.

@ErkkoI ErkkoI requested a review from DavidSAmundsen May 10, 2026 13:28
DavidSAmundsen
DavidSAmundsen reviewed May 19, 2026
View reviewed changes
Comment thread pyproject.toml Outdated
@ErkkoI ErkkoI requested a review from DavidSAmundsen May 19, 2026 19:18
@ErkkoI
Copy link
Copy Markdown
Contributor Author

ErkkoI commented May 20, 2026

Hi!
I missed your new comments in the previous comment threads.
I agree on both changing the heating_time variable names and the IVP implementation.
I will post a new comment when I finish with them so you can close the review or keep it open and wait for that whichever is better for you.

@ErkkoI
Copy link
Copy Markdown
Contributor Author

ErkkoI commented May 20, 2026

Ok, done with the implementation changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidSAmundsen DavidSAmundsen Awaiting requested review from DavidSAmundsen

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ErkkoI @DavidSAmundsen