Merged
Conversation
Contributor
|
Can I suggest disabling the nalgebra = { version = "0.29", default-features = false, features = ["std", "rand"] }
# or:
[dependencies.nalgebra]
version = "0.29"
default-features = false
features = ["std", "rand"]It looks like it is unnecessary for |
Contributor
Author
Contributor
|
Thanks! Another small thing, this one might be suited for this PR: The README uses CRLF line endings, which is a bit unexpected because all other files in the project seem to use LF only. Bit of a nitpick, but basically free to fix |
rely on docs.rs to have correct versino in url for docs
format markdown sentences to entire lines. add test status badge add usage of `cargo fmt` to contributing section
Contributor
Author
|
reordered commits in hopes to seem a little more organized. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few sets of chore commits
point at correct reponot explicit docs, since all on docs.rs