Support casting from string in embed#75
Open
feymartynov wants to merge 1 commit intostavro:masterfrom
Open
Conversation
|
hey guys! is it going anywhere? cc @stavro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use PostgresSQL's
JSON_AGGfunction which serializes rows from a joined table into single JSON field and then use Ecto'sembeds_manyto inflate them into structs. These structs have Arc type field. When Ecto calls cast/2 with a string of the formfile_name?updated_atas the second argument it matches the last definition which tries to store this string and fails but I expect it to do the same things asload/2does in this case. So here is my patch for it.