Skip to content

feat: add C implementation for blas/ext/base/ndarray/snansumkbn2 - #14051

Open
Siddhram wants to merge 3 commits into
stdlib-js:developfrom
Siddhram:feat/snansumkbn2
Open

feat: add C implementation for blas/ext/base/ndarray/snansumkbn2#14051
Siddhram wants to merge 3 commits into
stdlib-js:developfrom
Siddhram:feat/snansumkbn2

Conversation

@Siddhram

@Siddhram Siddhram commented Aug 8, 2026

Copy link
Copy Markdown

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C implementation for stats/base/ndarray/snansumkbn2

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@Siddhram
Siddhram requested a review from a team August 8, 2026 12:21
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Aug 8, 2026
@kgryte

kgryte commented Aug 8, 2026

Copy link
Copy Markdown
Member

In your addon.c file, you need to pass a const-qualified list of arrays. See ebbf2de.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Aug 8, 2026
@Siddhram

Siddhram commented Aug 8, 2026

Copy link
Copy Markdown
Author

In your addon.c file, you need to pass a const-qualified list of arrays. See ebbf2de.

I've updated addon.c to use a const-qualified list of arrays, following the referenced implementation. Please take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants