chore: add keyword - #14181
Merged
Merged
Conversation
…weibull` The Weibull distribution is continuous, but its package.json keywords omitted the `continuous` support-type tag. Added the tag to match the namespace convention: 29 of 30 continuous distributions in `stats/base/dists` carry `continuous` (97% conformance), and all 8 discrete distributions carry `discrete`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BMbL5NUYGNvoTGVxdZUpbJ
…nerate` The Usage section closed the constructor table of contents and went straight to the examples section, omitting the runnable constructor demonstration that every other constructor-bearing distribution in `stats/base/dists` includes immediately after the ctor toc (present in all ~30 sibling packages that expose a constructor). Added a demo constructing a `Degenerate` instance and reading its `mean` accessor, matching the sibling convention. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BMbL5NUYGNvoTGVxdZUpbJ
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 12, 2026 04:57
kgryte
approved these changes
Aug 12, 2026
stats/base/dists/degenerate and continuous keyword to weibull
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request corrects two cross-package API drift findings in the
@stdlib/stats/base/distsnamespace, detected by majority-vote comparison across the namespace's 39 distribution packages. Each fix brings a single outlier package into line with a convention shared by ≥97% of its siblings, without changing observable behavior or test expectations.@stdlib/stats/base/dists/weibullFixes the missing
continuoussupport-type tag in@stdlib/stats/base/dists/weibullpackage.json keywords. Weibull exposespdf,cdf,logpdf, andlogcdfbut carried neithercontinuousnordiscretein its keywords, an outlier against the rest ofstats/base/dists, where 29 of 30 continuous namespaces already carrycontinuousand all 8 discrete namespaces carrydiscrete. Addscontinuousto bring Weibull's keywords in line with the rest of the package family.@stdlib/stats/base/dists/degenerateAdds the missing constructor demonstration to
@stdlib/stats/base/dists/degenerate's README, immediately following the constructor table of contents. The Usage section jumped from the ctor toc straight to Examples, skipping the runnable snippet showingnew Degenerate( 2.0 ).meanreturning2.0. All ~30 sibling distributions exposing a constructor include this demo block; degenerate was the only constructor-bearing distribution without one.Related Issues
No related issues.
Questions
No.
Other
Namespace summary. 39 members analyzed (all non-autogenerated distribution-namespace aggregators). Structural features extracted per package: aggregator file tree,
package.jsonkey /scripts/stdlibshape, README heading sequence,manifest.jsonshape, andtest/examples/benchmarkfile naming. Semantic features extracted via one agent per package over eachlib/index.js. Two features carried a clear ≥75% majority and an outlier — the keyword support-type tag (97%) and the constructor-usage README demo (97%), both corrected here — alongside a large set of features at 100% conformance (file tree,package.jsonshape, README headings, test/example naming, member ordering, require-path style). Features excluded for lacking a clear majority:examples/index.jsnarrative-vs-dump style, theTODO: better examplesHTML-comment marker (85%, and regressive to re-add), and the intentional per-distribution moment/member sets.Validation. Each correction passed a three-agent review: (1) semantic review confirming the deviation is accidental drift rather than an intentional mathematical difference, (2) cross-reference confirming no test or example relies on the deviating state and no documented API contract breaks — the
degeneratedemo'snew Degenerate( 2.0 ).mean === 2.0return value was verified against source (degenerate/meanreturnsmuunchanged) — and (3) structural review confirming the majority pattern is the one that should be applied. Deliberately excluded from this PR: intentional deviations (e.g.degeneratelegitimately carrying no support-type keyword as a point mass; distributions exposing different moment functions), features without a clear majority, and fixes that would cascade into sibling or leaf packages (e.g. aplanckblockquote-link convention spanning 14 sub-package READMEs was logged and dropped).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running an automated cross-package drift-detection routine. It extracted structural and semantic features from all 39 packages in
stats/base/dists, identified the per-feature majority convention, flagged deviating packages, and validated each candidate correction through independent review agents before applying. Both changes are mechanical normalizations toward the namespace majority; a maintainer should review before merge.