Skip to content

test: migrate math/base/special/factorial to ULP-based assertions #14182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 1 commit into from
Aug 12, 2026
+6 −32
Merged

test: migrate math/base/special/factorial to ULP-based assertions #14182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions lib/node_modules/@stdlib/math/base/special/factorial/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,11 @@
// MODULES //

var tape = require( 'tape' );
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var incrspace = require( '@stdlib/array/base/incrspace' );
var abs = require( '@stdlib/math/base/special/abs' );
var PINF = require( '@stdlib/constants/float64/pinf' );
var NINF = require( '@stdlib/constants/float64/ninf' );
var EPS = require( '@stdlib/constants/float64/eps' );
var factorial = require( './../lib' );


Expand Down Expand Up @@ -103,8 +102,6 @@ tape( 'if `x < -171.56749...`, the function returns zero', function test( t ) {

tape( 'the function evaluates the factorial function (positive integers < 171)', function test( t ) {
var expected;
var delta;
var tol;
var x;
var v;
var i;
Expand All @@ -113,13 +110,7 @@ tape( 'the function evaluates the factorial function (positive integers < 171)',
expected = integers.expected;
for ( i = 0; i < x.length; i++ ) {
v = factorial( x[ i ] );
if ( v === expected[ i ] ) {
t.strictEqual( v, expected[ i ], 'returns '+expected[i]+' when provided '+x[i] );
} else {
delta = abs( v - expected[ i ] );
tol = EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. Value: ' + v + '. Expected: ' + expected[ i ] + '. Tolerance: ' + tol + '. Delta: ' + delta + '.' );
}
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'returns expected value' );
}
t.end();
});
Expand All @@ -136,8 +127,6 @@ tape( 'if provided positive integers greater than `170`, the function returns po

tape( 'the function evaluates the factorial function (decimal values)', function test( t ) {
var expected;
var delta;
var tol;
var x;
var v;
var i;
Expand All @@ -146,9 +135,7 @@ tape( 'the function evaluates the factorial function (decimal values)', function
expected = decimals.expected;
for ( i = 0; i < x.length; i++ ) {
v = factorial( x[ i ] );
delta = abs( v - expected[ i ] );
tol = 3.5 * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. Value: ' + v + '. Expected: ' + expected[ i ] + '. Tolerance: ' + tol + '. Delta: ' + delta + '.' );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 6 ), true, 'returns expected value' );
}
t.end();
});
19 changes: 3 additions & 16 deletions lib/node_modules/@stdlib/math/base/special/factorial/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,11 @@

var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var incrspace = require( '@stdlib/array/base/incrspace' );
var abs = require( '@stdlib/math/base/special/abs' );
var PINF = require( '@stdlib/constants/float64/pinf' );
var NINF = require( '@stdlib/constants/float64/ninf' );
var EPS = require( '@stdlib/constants/float64/eps' );
var tryRequire = require( '@stdlib/utils/try-require' );


Expand Down Expand Up @@ -112,8 +111,6 @@ tape( 'if `x < -171.56749...`, the function returns zero', opts, function test(

tape( 'the function evaluates the factorial function (positive integers < 171)', opts, function test( t ) {
var expected;
var delta;
var tol;
var x;
var v;
var i;
Expand All @@ -122,13 +119,7 @@ tape( 'the function evaluates the factorial function (positive integers < 171)',
expected = integers.expected;
for ( i = 0; i < x.length; i++ ) {
v = factorial( x[ i ] );
if ( v === expected[ i ] ) {
t.strictEqual( v, expected[ i ], 'returns '+expected[i]+' when provided '+x[i] );
} else {
delta = abs( v - expected[ i ] );
tol = EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. Value: ' + v + '. Expected: ' + expected[ i ] + '. Tolerance: ' + tol + '. Delta: ' + delta + '.' );
}
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'returns expected value' );
}
t.end();
});
Expand All @@ -145,8 +136,6 @@ tape( 'if provided positive integers greater than `170`, the function returns po

tape( 'the function evaluates the factorial function (decimal values)', opts, function test( t ) {
var expected;
var delta;
var tol;
var x;
var v;
var i;
Expand All @@ -155,9 +144,7 @@ tape( 'the function evaluates the factorial function (decimal values)', opts, fu
expected = decimals.expected;
for ( i = 0; i < x.length; i++ ) {
v = factorial( x[ i ] );
delta = abs( v - expected[ i ] );
tol = 3.5 * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. Value: ' + v + '. Expected: ' + expected[ i ] + '. Tolerance: ' + tol + '. Delta: ' + delta + '.' );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 6 ), true, 'returns expected value' );
}
t.end();
});