Skip to content

style: add missing spaces - #14201

Merged
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-08-12
Aug 12, 2026
Merged

style: add missing spaces#14201
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-08-12

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-08-11 16:39 PT (99b2dea) and 2026-08-12 01:35 PT (6e66cf0).

This pull request:

  • blas/ext/base/ndarray/ccopy-within: fix indentation in blas/ext/base/ndarray/ccopy-within's .d.ts @example blocks: the 'dtype' lines are 4-space indented, one space short of the repo convention — same issue already fixed at the namespace level in 7026843, just missed here (from ba1e337). Re-indents the 4 lines to 5 spaces to match scopy-within and sibling packages.
  • blas/ext/base/ndarray/zcopy-within: fix zcopy-within types example indentation to 5 spaces; blas/ext/base/ndarray/zcopy-within/docs/types/index.d.ts ('dtype' lines) missed the 5-space convention applied to the namespace declarations in 7026843 (from 6dbb82e). Re-indents all four occurrences to match scopy-within and the rest of the tree.
  • stats/base/dists/arcsine/logcdf: fix expected[i]expected[ i ] in the six lines added by 99b2dea for the arcsine logcdf ULP migration, in test/test.factory.js and test/test.logcdf.js (3 lines each); leaves the untouched unspaced lines alone, matching every other ULP migration in this window.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation performed on the 40-commit window:

  • Style guide compliance audit (two independent passes) of all hand-written changes against docs/style-guides and established sibling packages (new blas/ext/base/ndarray packages compared against scopy-within, dfill-equal, sfirst-index-equal, dindex-of-falsy, etc.).
  • Bug scan (two independent passes) over the introduced code: loop bounds, stride/offset arithmetic, boundary normalization, dtype copy-paste slips, doc example outputs, and test assertions. No bugs found.
  • Deliberately excluded: subjective concerns, style preferences not required by the style guide, anything requiring interpretation, and anything whose validation or fix would require touching code outside the window's diff (e.g. pre-existing unspaced array indices on lines not modified in the window).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of a scheduled automated review of commits recently merged to develop; all fixes were machine-proposed, cross-verified against the style guide and sibling packages, and are pending human audit (hence the draft state).

🤖 Generated with Claude Code

https://claude.ai/code/session_013h4HJcwR26t7SJGpuzB7rt


Generated by Claude Code

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray/ccopy-within $\\color{green}157/157$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}157/157$
$\\color{green}+100.00\\%$
blas/ext/base/ndarray/zcopy-within $\\color{green}157/157$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}157/157$
$\\color{green}+100.00\\%$
stats/base/dists/arcsine/logcdf $\\color{green}237/237$
$\\color{green}+100.00\\%$
$\\color{green}25/25$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}237/237$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review August 12, 2026 23:06
@kgryte
kgryte requested a review from a team August 12, 2026 23:06
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 12, 2026
@kgryte kgryte changed the title style: add missing spaces in recently merged packages and tests style: add missing spaces Aug 12, 2026
@kgryte
kgryte merged commit 6f563d5 into develop Aug 12, 2026
34 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-08-12 branch August 12, 2026 23:07
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants