test: migrate stats/base/dists/normal/entropy to ULP-based assertions - #14227
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012zq2vJK9SzKxmfqXKTCTQQ
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/normal/entropyfrom relative tolerance assertions to ULP-based assertions.delta/tolcomputations intest/test.jsandtest/test.native.jswithisAlmostSameValue( y, expected[ i ], N )and adds the corresponding@stdlib/assert/is-almost-same-valuerequire, removing the now unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires.ULP bounds
Both files use a bound of 1 ULP, which is the measured minimum for the full Julia fixture set:
test/test.js1.0 * EPS * abs( expected[ i ] )11test/test.native.js1.0 * EPS * abs( expected[ i ] )11The bound was tightened by starting high and lowering to the smallest passing integer. At
1the suite is green; at0six assertions fail, so1is the minimum. The JS and C implementations evaluate the identical expression (0.5 * ln( TWO_PI * E * sigma * sigma )using stdlib's ownln), and the native add-on was built locally and measured independently, also yielding a maximum of1ULP over the fixtures, hence the same bound in both files.Verification:
make test TESTS_FILTER=".*/stats/base/dists/normal/entropy/.*"passes (20 assertions fortest.js; 21 fortest.native.jswith the add-on built), run three times with identical results, so the bound is not sensitive to FMA/arch variation.etc/eslint/.eslintrc.tests.js.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The conversion mirrors the idiom used in previously merged conversions in the same family, most closely
stats/base/dists/logistic/entropy(#14218).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which studied previously merged ULP migrations in this repository, applied the same idiom, and empirically determined the minimum ULP bound by running the test suite.
@stdlib-js/reviewers
Generated by Claude Code