test: migrate stats/base/dists/normal/cdf to ULP-based assertions - #14274
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WV2qNsAmgD64jXpf6VsWSt
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 15, 2026 02:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/normal/cdffrom relative tolerance testing to ULP difference testing, as described in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.Changes are confined to
test/test.cdf.js,test/test.factory.js, andtest/test.native.js. In each fixture loop,var delta/var toland theabs( y - expected[i] ) <= EPS * abs( expected[i] )comparison are replaced witht.strictEqual( isAlmostSameValue( y, expected[ i ], N ), true, 'returns expected value' ), and the now-unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires are removed in favor of@stdlib/assert/is-almost-same-value.The ULP bounds were measured against the full fixture set (1000 cases per fixture) and tightened to the minimum passing integer:
positive_mean.json1600.0 * EPS2207negative_mean.json1600.0 * EPS2433large_variance.json250.0 * EPS4Each bound is the measured maximum ULP difference over its fixture, and is minimal: lowering any of them by one causes that fixture to fail. The same bounds apply to all three test files, as the C implementation returns bit-identical values to the JavaScript implementation for all 3000 fixture cases (verified locally with the native add-on built), so no JS vs. C divergence needed to be accounted for.
The full package test suite (
make test TESTS_FILTER=".*/stats/base/dists/normal/cdf/.*") passes, includingtest.native.jsagainst a locally built add-on, and was run twice at the final ULP values to confirm the results are deterministic.make eslint-testsis clean for the package.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, following the migration pattern established in previously merged conversions (e.g. #14267, #14258, #14272). The ULP bounds were determined empirically by measuring ULP differences across the full fixture set and verifying minimality, rather than guessed.
@stdlib-js/reviewers