ci: Fix remaining Dependabot alerts with npm overrides.#279
Conversation
449f314 to
252b813
Compare
There was a problem hiding this comment.
Pull request overview
Adds npm overrides to remediate Dependabot-reported vulnerabilities in transitive dependencies used by the repo’s Node-based tooling (commit hooks / release tooling), and updates package-lock.json accordingly.
Changes:
- Adds
overridesinpackage.jsonforpicomatch,lodash,tmp, andbrace-expansion. - Updates
package-lock.jsonto reflect the overridden dependency graph (notablybrace-expansionandtmpupgrades, and removal of some now-unneeded nested deps).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| package.json | Introduces npm overrides to force patched transitive dependency versions. |
| package-lock.json | Updates the resolved dependency tree to match the new overrides. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "tmp": "^0.2.4", | ||
| "brace-expansion": "^2.0.3" |
There was a problem hiding this comment.
The PR description mentions tmp 0.2.4, but with the current override ("^0.2.4") the lockfile resolves tmp to 0.2.5. Consider updating the PR description (or pinning the override) so the documented remediation matches what npm will actually install.
|
Les 4 commentaires Copilot ont été analysés :
|
Summary
Add npm
overridesinpackage.jsonto force patched versions of vulnerable transitive dependencies:Reduces Dependabot alerts from 8 to 2. The 2 remaining are bundled inside npm internal (
node_modules/npm/node_modules/) and cannot be overridden.Closes #280
Copilot review notes
Copilot suggested downgrading picomatch to 2.3.2 and brace-expansion to 1.1.12 for semver compatibility. These suggestions are incorrect: picomatch 2.3.2 IS the vulnerable version (the fix is 4.0.4+), and brace-expansion 1.x is not affected by the same advisory (GHSA-f886-m6hf-6m8v targets 2.0.0–2.0.2). The overrides are correct as-is.
Test plan
npm auditgoes from 7 to 2 vulnerabilitiesmake cipasses (lint + 271 tests)