Continuous intermediate variables + population dynamics#151
Continuous intermediate variables + population dynamics#151FedericoFlorio wants to merge 183 commits intostecrotti:mainfrom
Conversation
This modification prevents different times to be bound together.
Bugs are present yet that put derivatives to 0 for large graphs and long times
|
The problem with these tests is that the new version of TensorTrains (my last merge) is not loaded here. |
| λ :: Vector{F} | ||
| ρ :: Vector{F} | ||
| α :: Vector{F} | ||
| λ :: SparseMatrixCSC{F} # infection probabilities |
There was a problem hiding this comment.
I'll do some nitpicking (as @abraunst would say :) ) and point out that if we're storing lambda as a matrix we don't really need the graph anymore.
If you feel like changing it it would be clearner, otherwise no big deal
There was a problem hiding this comment.
Yes, I guess we can leave this file as it is.
Frankly, I did not intend to modify this, I think I messed up a bit with the rebase.
I guess I cannot edit the PR, can you?
There was a problem hiding this comment.
Just push changes to your branch, the PR gets automatically updated.
|
I can release a new version of TensorTrains with your updates in it. After that you'll need to update this PR by setting the dependency of MPBP on Tensor Trains at the new version. Should i merge and include stecrotti/TensorTrains.jl#92 in the release? |
|
I think so. But let's wait @abraunst |
It's not needed for this PR, but indeed it would be nice to have stecrotti/TensorTrains.jl#92 in the release. |
done :) |
3 participants
Here, two features are introduced: