Skip to content
This repository was archived by the owner on Feb 1, 2021. It is now read-only.

fix: strip .git off url properly#43

Merged
stefanprodan merged 1 commit into
stefanprodan:masterfrom
docwhat:pr-docwhat/fix-git-url-munging
Sep 29, 2020
Merged

fix: strip .git off url properly#43
stefanprodan merged 1 commit into
stefanprodan:masterfrom
docwhat:pr-docwhat/fix-git-url-munging

Conversation

@docwhat
Copy link
Copy Markdown
Contributor

@docwhat docwhat commented Sep 24, 2020

basename is too aggressive and removes the hostname and path.

`basename` is too aggressive and removes the hostname and path.
@docwhat
Copy link
Copy Markdown
Contributor Author

docwhat commented Sep 24, 2020

This does what I think #41 is trying to do.

Closes: #41

Copy link
Copy Markdown
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan merged commit 1e61958 into stefanprodan:master Sep 29, 2020
@docwhat docwhat deleted the pr-docwhat/fix-git-url-munging branch September 29, 2020 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants