Feature/Fix: Contain ambiguous lineage families#2146
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 13, 2026, 9:19 PM ET / July 14, 2026, 01:19 UTC. Summary Reproducibility: yes. at source level: the canonical issue and merged sanitized fixtures establish interleaved and fork-family accounting failures with hand oracles, but this branch's new ledger behavior has not been demonstrated on the affected private corpus. Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Land the lineage ledger as a bounded, cancellation-safe shadow pipeline rebased onto its prerequisite, with reconciliation bounds included or shadow execution gated off, plus redacted initial and cached repeat-scan proof from an affected corpus before any future promotion into authoritative totals. Do we have a high-confidence way to reproduce the issue? Yes at source level: the canonical issue and merged sanitized fixtures establish interleaved and fork-family accounting failures with hand oracles, but this branch's new ledger behavior has not been demonstrated on the affected private corpus. Is this the best way to solve the issue? Unclear as an isolated merge unit. The architecture matches the deferred cross-file provenance direction, but it should be bounded, cancellation-safe, and live-proven before production shadow execution lands. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 0437067deaa8. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Superseded by the consolidated four-PR review stack. This slice is now included in #2157; closing this draft to keep the upstream review surface manageable. |
Stack dependency
This is slice 7 of 15. It follows Feature/Fix: Classify shadow lineage residuals; review and merge that PR first.
Summary
This is another isolated component of the planned Codex scanner rearchitecture. It keeps the production legacy total authoritative while making shadow accounting safer around malformed and ambiguous rollout histories.
Validation
swift test --filter 'CodexLineage(Shadow|Ledger|Discovery)Tests'(28 passed)make checkenv SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.5.sdk make test(642 selections, 54 groups, no failures or retries)Related investigation: steipete/CodexBar#2037.