feat(summarize): add Linux x64 and arm64 support#18
Closed
yetmike wants to merge 1 commit intosteipete:mainfrom
Closed
feat(summarize): add Linux x64 and arm64 support#18yetmike wants to merge 1 commit intosteipete:mainfrom
yetmike wants to merge 1 commit intosteipete:mainfrom
Conversation
Replace the single flat url/sha256 + `depends_on arch: :arm64` with
on_macos / on_linux blocks so the formula works on Linux hosts.
Platforms covered:
- macOS ARM64 (existing, unchanged sha256)
- Linux x86_64 (on_linux { on_intel })
- Linux ARM64 (on_linux { on_arm })
The Linux sha256 placeholders will be replaced on the next release by
`bash scripts/release.sh tap` in steipete/summarize, which downloads
all three tarballs, computes their sha256s, and rewrites this file.
Linux binaries are built automatically by the new CI workflow
(.github/workflows/build-binary.yml) in steipete/summarize and
uploaded to the GitHub release alongside the macOS artifact.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5 tasks
Owner
|
Closing because current main fixed the reported bad Linux behavior by making summarize explicitly macOS-only, while this PR is stale/conflicting and still contains placeholder Linux SHA256 values. Linux support can come back once real Linux release artifacts exist. Thanks @yetmike for digging into the path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructures
Formula/summarize.rbto support Linux x64 and arm64 in addition to macOS ARM64, by replacing the single flaturl/sha256+depends_on arch: :arm64withon_macos/on_linuxblocks.Platforms covered after this change:
on_macos { on_arm }— existing sha256, unchangedon_linux { on_intel }on_linux { on_arm }Merge order
pnpm build:bun:all:test(cross-compiles all three platforms from macOS) and updatesscripts/release.sh tapto rewrite this formula with real sha256s automatically.pnpm build:bun:all:test, create the GitHub release with all five assets (3 Bun tarballs + Chrome zip + Firefox zip).bash scripts/release.sh tap— downloads all three tarballs, computes sha256s, rewrites the formula. Commit & push.Linux sha256 placeholders
The two Linux
sha256values are currently0000…because no Linux release assets exist yet onsteipete/summarize. They will be replaced byscripts/release.sh tapin step 3 above before this is merged.Test plan
pnpm build:bun:all:testproduces all three tarballsbash scripts/release.sh tapfills in real sha256sbrew tap steipete/tap && brew install summarize && summarize --versionbrew upgrade summarizestill works🤖 Generated with Claude Code