Skip to content

Hide memo row on unrelated operations#798

Open
leofelix077 wants to merge 4 commits intomainfrom
lf-hide-memo-field-on-unrelated-operations
Open

Hide memo row on unrelated operations#798
leofelix077 wants to merge 4 commits intomainfrom
lf-hide-memo-field-on-unrelated-operations

Conversation

@leofelix077
Copy link
Copy Markdown
Collaborator

@leofelix077 leofelix077 commented Apr 2, 2026

Closes #694

iOS Build 1775473054 📱


Screenshot 2026-04-02 at 14 13 10 Screenshot 2026-04-02 at 14 13 29 Screenshot 2026-04-02 at 14 14 08 Screenshot 2026-04-02 at 14 14 18 Screenshot 2026-04-02 at 14 14 32 Screenshot 2026-04-06 at 09 10 28

Checklist

PR structure

  • This PR does not mix refactoring changes with feature changes (break it down into smaller PRs if not).
  • This PR has reasonably narrow scope (break it down into smaller PRs if not).
  • This PR includes relevant before and after screenshots/videos highlighting these changes.
  • I took the time to review my own PR.

Testing

  • These changes have been tested and confirmed to work as intended on Android.
  • These changes have been tested and confirmed to work as intended on iOS.
  • I have tried to break these changes while extensively testing them.
  • This PR adds tests for the new functionality or fixes.

Release

  • This is not a breaking change.
  • This PR updates existing JSDocs when applicable.
  • This PR adds JSDocs to new functionalities.
  • I've checked with the product team if we should add metrics to these changes.
  • I've shared relevant before and after screenshots/videos highlighting these changes with the design team and they've approved the changes.

@leofelix077 leofelix077 self-assigned this Apr 2, 2026
@leofelix077 leofelix077 added the don't review yet Work in Progress / Draft PR / Code Review adjustments being worked on label Apr 2, 2026
Copilot AI review requested due to automatic review settings April 2, 2026 17:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the History transaction details bottom sheet to avoid showing the “Memo” row for transaction types where the memo isn’t intended to be surfaced, while preserving the existing behavior of hiding memo for muxed (M...) destinations.

Changes:

  • Added a shouldShowMemo() helper to centralize the memo-row visibility rule.
  • Updated TransactionDetailsBottomSheetCustomContent to use shouldShowMemo() (show only for Payment/CreateAccount and non-muxed destinations).
  • Added unit tests covering the memo visibility logic.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/components/screens/HistoryScreen/TransactionDetailsBottomSheetCustomContent.tsx Uses the new helper to conditionally include the memo row only for relevant transaction types / destinations.
src/components/screens/HistoryScreen/helpers.tsx Adds shouldShowMemo() and documentation describing the display rule.
src/components/screens/HistoryScreen/helpers.test.ts Adds Jest coverage for shouldShowMemo() across classic/non-classic transaction types and muxed/non-muxed destinations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leofelix077 leofelix077 added enhancement New feature or request and removed don't review yet Work in Progress / Draft PR / Code Review adjustments being worked on labels Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show history memo only for Send/Receive

2 participants