Draft
Conversation
Shaptic
reviewed
Mar 3, 2026
Shaptic
reviewed
Mar 3, 2026
Shaptic
reviewed
Mar 3, 2026
Shaptic
reviewed
Mar 3, 2026
cjonas9
force-pushed
the
simulate-and-send-transactions
branch
from
76bc86b to
b4c0fa5
Compare
Shaptic
reviewed
Mar 7, 2026
Shaptic
reviewed
Mar 7, 2026
cjonas9
force-pushed
the
simulate-and-send-transactions
branch
from
018c56e to
d6bfa8e
Compare
Shaptic
reviewed
Mar 12, 2026
Shaptic
reviewed
Mar 13, 2026
Shaptic
reviewed
Mar 16, 2026
| if endpointKey == "sendTransaction" { | ||
| numAccounts := uint32(min(rps, 100)) // cap # of accounts to lessen friendbot calls and account creation | ||
|
|
||
| logger.Warn("sendTransaction causes greater load on the RPC server than other endpoints!") |
| if err != nil { | ||
| return "", fmt.Errorf("failed to submit create account transaction: %v", err) | ||
| } | ||
| if resp.Status == proto.TXStatusError { |
| } | ||
|
|
||
| w.Id.Store(seq + 1) | ||
| w.Balance.Swap(w.Balance.Load() - amount*int64(len(to))) |
There was a problem hiding this comment.
This isn't accurate until the tx is confirmed, no?
|
|
||
| // BuildSimulateTxB64 builds a base64-encoded PaymentToContract used for simulateTransaction calls. | ||
| // Uses zero contract/source accounts - no real accounts needed since this is never submitted on-chain. | ||
| func BuildSimulateTxB64(networkPassphrase string) (string, error) { |
There was a problem hiding this comment.
Since send and simulate are disjoint, it'd be super helpful to be able to review these independently. In the interest of smaller PRs, could we decompose these into separate ones?
| StroopsPerXLM = 1 * 1e7 | ||
| FeeTolerance = 1000 // stroop-fee buffer to account for fee fluctuations when verifying balances | ||
|
|
||
| WorkerMergeRetryWindow = time.Second * 90 |
There was a problem hiding this comment.
Shouldn't this scale with MaxCreateAccountsPerTx?
| sa := p.originAccount | ||
| accounts := make([]*WorkerAccount, numWorkers) | ||
| for i := range accounts { | ||
| workerKp, err := keypair.Random() |
There was a problem hiding this comment.
If we derive these deterministically from the base account, we can have a reproducible setup stage and make merges idempotent
Shaptic
reviewed
Mar 16, 2026
Comment on lines
+26
to
+32
| export ORIGIN_ACCOUNT_SECRET="S..." | ||
|
|
||
| ./stellar-rpc-blaster run \ | ||
| --rpc-url "https://your-rpc-host" \ | ||
| --config-path "./internal/config/config.example.toml" \ | ||
| --duration 30s \ | ||
| --ramp-up 10s |
There was a problem hiding this comment.
Recommend making the secret ephemerally available rather than globally for the shell duration:
Suggested change
| export ORIGIN_ACCOUNT_SECRET="S..." | |
| ./stellar-rpc-blaster run \ | |
| --rpc-url "https://your-rpc-host" \ | |
| --config-path "./internal/config/config.example.toml" \ | |
| --duration 30s \ | |
| --ramp-up 10s | |
| ORIGIN_ACCOUNT_SECRET="S..." ./stellar-rpc-blaster run \ | |
| --rpc-url "https://your-rpc-host" \ | |
| --config-path "./internal/config/config.example.toml" \ | |
| --duration 30s \ | |
| --ramp-up 10s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR is currently not to be reviewed, as significant changes to the base branch are underway.
What
Adds support for
simulateTransactionandsendTransactionas load-testable RPC endpoints:simulateTransactionbuilds a static PaymentToContract transaction with zero account IDs and zero destination contract IDs. Sent at rateRPSin a manner similar to non-data-dependent endpoints.sendTransaction, if one is testing ontestnet,they have the option of not supplying a pre-funded user account. However, they may if they wish, and if they wish to test onpubnet, then they must. This can be specified in thetomlfile as a secret seed from which their keypair may be parsed.Why
These are the final endpoints that must be supported by stellar-rpc-blaster, and differ from the others because they're not read-only. They require actual signed transaction envelopes rather than canned JSON parameters. This branch builds transaction construction, account lifecycle (source account -> workers seeded with funds -> workers coalesced into source account), and infrastructure needed to generate realistic load against these endpoints.
Known limitations
N/A