Ungate CAP_0083 and CAP_0085_EXECUTABLE_REF ifdefs - #311
Merged
Conversation
Remove the #ifdef CAP_0083 and #ifdef CAP_0085_EXECUTABLE_REF preprocessor gating so both CAPs' XDR definitions are unconditionally present on main, and therefore land in curr as well as next. Folds the gated leading/trailing commas in the StellarValueType, SCValType and ContractExecutableType enums back onto the preceding line. CAP_0084_MUXED_CONTRACT stays gated — it is still a SPIKE.
Contributor
There was a problem hiding this comment.
Pull request overview
Ungates CAP-0083 and CAP-0085 XDR definitions so they generate in both curr and next.
Changes:
- Makes empty transaction-set ledger values unconditional.
- Makes executable tags and external executable references unconditional.
- Keeps CAP-0084 gating intact.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Stellar-ledger.x |
Ungates CAP-0083 enum and union arms. |
Stellar-contract.x |
Ungates CAP-0085 executable-reference definitions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dmkozh
approved these changes
Jul 29, 2026
This was referenced Jul 29, 2026
sisuresh
added a commit
to sisuresh/stellar-core
that referenced
this pull request
Jul 30, 2026
Removes the CAP_0083 and CAP_0085_EXECUTABLE_REF ifdefs and their configure.ac / common.mk / Makefile.am wiring, so both CAPs compile unconditionally. EMPTY_TX_SET_PROTOCOL_VERSION and EXTERNAL_EXECUTABLE_REF_PROTOCOL_VERSION are now always V_28 rather than falling back to V_UINT32_MAX; activation stays gated at runtime by protocolVersionStartsFrom. Bumps Config::CURRENT_LEDGER_PROTOCOL_VERSION to 28. Repins src/protocol-curr/xdr to stellar/stellar-xdr#311 (9c9c145, where the ifdefs were removed) and the p28 soroban host to stellar/rs-soroban-env#1715 (eec5eea2). The host bump also brings in CAP-0086 (sparse Symbol-keyed map host functions), which needs no ungating of its own: it has no XDR changes and landed in the host unconditionally, gated only by min_supported_protocol 28.
sisuresh
added a commit
to sisuresh/stellar-core
that referenced
this pull request
Jul 30, 2026
Removes the CAP_0083 and CAP_0085_EXECUTABLE_REF ifdefs and their configure.ac / common.mk / Makefile.am wiring, so both CAPs compile unconditionally. EMPTY_TX_SET_PROTOCOL_VERSION and EXTERNAL_EXECUTABLE_REF_PROTOCOL_VERSION are now always V_28 rather than falling back to V_UINT32_MAX; activation stays gated at runtime by protocolVersionStartsFrom. Bumps Config::CURRENT_LEDGER_PROTOCOL_VERSION to 28. Repins src/protocol-curr/xdr to stellar/stellar-xdr#311 (9c9c145, where the ifdefs were removed) and the p28 soroban host to stellar/rs-soroban-env#1715 (eec5eea2). The host bump also brings in CAP-0086 (sparse Symbol-keyed map host functions), which needs no ungating of its own: it has no XDR changes and landed in the host unconditionally, gated only by min_supported_protocol 28.
sisuresh
added a commit
to sisuresh/stellar-core
that referenced
this pull request
Jul 30, 2026
Removes the CAP_0083 and CAP_0085_EXECUTABLE_REF ifdefs and their configure.ac / common.mk / Makefile.am wiring, so both CAPs compile unconditionally. EMPTY_TX_SET_PROTOCOL_VERSION and EXTERNAL_EXECUTABLE_REF_PROTOCOL_VERSION are now always V_28 rather than falling back to V_UINT32_MAX; activation stays gated at runtime by protocolVersionStartsFrom. Bumps Config::CURRENT_LEDGER_PROTOCOL_VERSION to 28. Repins src/protocol-curr/xdr to stellar/stellar-xdr#311 (9c9c145, where the ifdefs were removed) and the p28 soroban host to stellar/rs-soroban-env#1715 (eec5eea2). The host bump also brings in CAP-0086 (sparse Symbol-keyed map host functions), which needs no ungating of its own: it has no XDR changes and landed in the host unconditionally, gated only by min_supported_protocol 28. bump quorum analyzer Bump env update test remove tx tag
pull Bot
pushed a commit
to mikeyhodl/stellar-core
that referenced
this pull request
Jul 31, 2026
Removes the `CAP_0083` and `CAP_0085_EXECUTABLE_REF` ifdefs and their `configure.ac` / `common.mk` / `Makefile.am` wiring, so both compile unconditionally. The two protocol constants are now always `V_28` instead of falling back to `V_UINT32_MAX`; activation is still gated at runtime by `protocolVersionStartsFrom`. Bumps `CURRENT_LEDGER_PROTOCOL_VERSION` to 28. Repins `src/protocol-curr/xdr` to stellar/stellar-xdr#311 and the p28 host to stellar/rs-soroban-env#1715. The host bump also brings in CAP-0086, which needs no ungating of its own — no XDR changes, and it landed in the host unconditionally. Last of the P28 ungating stack (stellar-xdr#311 → rs-stellar-xdr#565 → rs-soroban-env#1715 → this).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
#ifdef CAP_0083and#ifdef CAP_0085_EXECUTABLE_REFgating so both CAPs' definitions are unconditional and land incurras well asnext. Same shape as #303.CAP_0084_MUXED_CONTRACTstays gated. CAP-0086 has no XDR changes.First of the P28 ungating stack: rs-stellar-xdr → rs-soroban-env → stellar-core follow.