chore: add common OS, IDE, and tooling patterns to .gitignore#8
Open
mertcicekci0 wants to merge 1 commit intostellar:mainfrom
Open
chore: add common OS, IDE, and tooling patterns to .gitignore#8mertcicekci0 wants to merge 1 commit intostellar:mainfrom
mertcicekci0 wants to merge 1 commit intostellar:mainfrom
Conversation
Add missing entries for macOS (.DS_Store), Windows (Thumbs.db), IDE directories (.idea, .vscode), editor swap files, log files, and test coverage output.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marcelosalloum
added a commit
that referenced
this pull request
Mar 17, 2026
### What Addresses 6 findings from the [Bug Finder Report](stellar/internal-agents#136) that apply to our codebase. Each fix is a separate commit: | Finding | Severity | Commit | File | Fix | |---------|----------|--------|------|-----| | #5 | High | `guard against concurrent payment submissions` | `useStellarPayment.ts` | Add `useRef(false)` synchronous guard to prevent double-click / rapid resubmission of the same payment | | #8 | Medium | `add missing return after insufficient balance error` | `StellarPaywall.tsx` | Add `return` after setting insufficient-balance error to prevent fall-through into payment submission | | #9 | Medium | `use fresh 402 requirements on payment retry` | `useStellarPayment.ts` | On retry, decode the `PAYMENT-REQUIRED` header from the 402 response instead of reusing the potentially stale original prop | | #12 | Medium | `add fetch timeout to facilitator validation` | `env.ts` | Add `AbortController` with 10 s timeout to `validateFacilitators()` fetch so startup doesn't hang if a facilitator is unresponsive | | #13 | Medium | `copy handler array at build time` | `builder.ts` | Snapshot `this.handlers` with spread at `build()` time so later mutations to the builder don't affect already-built providers | | #14 | Medium | `guard parseFloat NaN in paywall amount` | `stellar-handler.ts` | Wrap `parseFloat` result with `Number.isFinite()` and fall back to `0` to prevent `NaN` from propagating into the paywall HTML | ### Why An automated security audit ([stellar/internal-agents#136](stellar/internal-agents#136)) reported 15 findings (7 high, 8 medium). After triaging all 15, 6 are actionable in our code — the rest are either already fixed or require upstream changes to [`coinbase/x402`](https://github.com/coinbase/x402). Closes stellar/internal-agents#136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing entries for macOS (.DS_Store), Windows (Thumbs.db), IDE directories (.idea, .vscode), editor swap files, log files, and test coverage output.