feat(middleware): normalize asset code parameters to uppercase#233
Merged
Sulex45 merged 1 commit intoJun 2, 2026
Merged
Conversation
|
@Aycode01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #217
Summary
This PR introduces an asset code normalization middleware that automatically converts asset code parameters to uppercase across asset-related routes. This eliminates case-sensitivity issues and ensures consistent asset code handling without requiring developers to manually normalize input.
Type of Change
Bug fix
New feature
Breaking change
Refactor
Documentation
Changes Made
Added normalizeAssetCode middleware at src/middleware/normalizeAssetCode.js
Automatically uppercases req.params.code when present
Automatically uppercases req.query.code when present
Applied middleware to all asset-related routes
Preserved existing behavior for already-uppercase asset codes
Added test coverage for route params, query params, and edge cases
Testing Done
Verified lowercase asset codes are normalized to uppercase
Verified mixed-case asset codes are normalized correctly
Verified already-uppercase asset codes remain unchanged
Tested query parameter normalization
Tested missing code parameters do not cause errors
Verified unrelated request parameters remain untouched
Ran project test suite successfully
Screenshots
N/A (backend middleware change)
Checklist
Code follows the project's style guidelines
Self-review completed
Tests added/updated for changes
Documentation updated if needed
No secrets or credentials in the code
Smart contract changes reviewed for security implications (N/A)