Conversation
nikolaystrikhar
previously approved these changes
May 1, 2026
estevao90
dismissed stale reviews from jonwaldstein and nikolaystrikhar
via
d11035f
jonwaldstein
approved these changes
May 1, 2026
Contributor
jonwaldstein
left a comment
jonwaldstein
left a comment
There was a problem hiding this comment.
Looks good, @pauloiankoski can you review too please
pauloiankoski
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how upgrade URLs are generated and routed in the application, particularly for users looking to upgrade their subscriptions. The main change is the replacement of the old
change-planURL logic with a new mechanism that uses catalog-providedupgrade_urlvalues, including the addition of portal tracking parameters. This ensures that upgrade CTAs (calls to action) direct both existing and new users to the correct destination with improved tracking and context.Demo: https://www.loom.com/share/c88f0447c73c402bb50e8210b05180df