Skip to content

fix: make store selector stable #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stepan662 merged 1 commit into from
Jun 8, 2026
Merged

fix: make store selector stable #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/src/useContextSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {
createContext as createContextOrig,
useCallback,
useContext as useContextOrig,
useDebugValue,
useEffect,
Expand Down Expand Up @@ -62,9 +63,15 @@ export function useContextSelector<T, X>(
selector: (value: T) => X,
) {
const store = useContextOrig(context as React.Context<Store<T>>);
const selectorRef = useRef(selector);
selectorRef.current = selector;
const getSnapshot = useCallback(
() => selectorRef.current(store?.value),
[store],
);
const selected = useSyncExternalStore(
store?.subscribe ?? dummySubscribe,
() => selector(store?.value),
getSnapshot,
);
useDebugValue("react-arven");
return selected;
Expand Down
Loading