[codex] fix embedding server URL configuration#38
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughAdds URL-based embedding-function configuration across collection drafting, copying, document selection, IPC parsing, and seed fixtures, with validation helpers and updated README notes for mixed-dimension test data. ChangesEmbedding Function URL Support
Sequence Diagram(s)sequenceDiagram
participant EmbeddingFunctionSelector
participant validateEmbeddingFunctionUrl
participant buildEmbeddingFunctionOverride
EmbeddingFunctionSelector->>validateEmbeddingFunctionUrl: validate customUrl
validateEmbeddingFunctionUrl-->>EmbeddingFunctionSelector: error text or null
EmbeddingFunctionSelector->>buildEmbeddingFunctionOverride: build override with url
buildEmbeddingFunctionOverride-->>EmbeddingFunctionSelector: EmbeddingFunctionOverride
EmbeddingFunctionSelector->>EmbeddingFunctionSelector: onSave with override
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes #37 by making custom embedding server URLs configurable wherever users choose client-side embedding functions.
What changed
Root cause
The Electron service and IPC contract already accepted
embeddingFunction.url, and HuggingFace Server requires it, but the renderer only submitted the static embedding preset value. For HuggingFace Server that preset URL was empty, and there was no UI to enter a custom URL.Validation
pnpm typecheckpnpm lintpnpm testpnpm checkpnpm test:smokeNote: smoke build logs still include existing Sentry invalid-token upload warnings, but the build and Playwright smoke test completed successfully.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation