Change is-hidden to vertical-timeline-is-hidden to avoid naming conflict#97
Open
dbudwin wants to merge 4 commits intostephane-monnot:masterfrom
Open
Change is-hidden to vertical-timeline-is-hidden to avoid naming conflict#97dbudwin wants to merge 4 commits intostephane-monnot:masterfrom
dbudwin wants to merge 4 commits intostephane-monnot:masterfrom
Conversation
Most versions were updated to their latest with the exception of `react` and `react-dom`. This was to satisfy some version constraints imposed by other packages. Even though everything would likely work nicely with React 17, I upped to the latest version of React 16 to play it safe. This removes one dependency, `@babel/preset-es2015`. It gives the following message: "We've deprecated any official yearly presets in 6.x in favor or babel-preset-env. For 7.x it would be @babel/preset-env." This also adds one dependency, `eslint-plugin-react-hooks`. This is to satisfy a new constraint imposed by `eslint-config-airbnb`.
This issue stemmed from bug stephane-monnot#95 related to jumping scrolling in SPA's that use Bulma. This is implementing the suggested fix. Co-authored-by: Stéphane Monnot <monnot.stephane@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 14 14
Branches 5 5
=========================================
Hits 14 14
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue stemmed from bug #95 related to jumping scrolling in SPA's that use Bulma. This is implementing the suggested fix.
This changes the major version from 3 to 4. I figured it could be considered a breaking change if users of this package are relying upon the old
is-hiddenCSS property.Co-authored-by: Stéphane Monnot monnot.stephane@gmail.com