-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add more traits to Package.swift #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
79e44e7
Traits automatically set up define with the trait name
jberkel df532ad
Clean up Package.swift
jberkel 47e50bf
Convert into trait
jberkel 30fe303
Update xcbeautify
jberkel e5f413a
Use traits for other configurations
jberkel e247227
Use traits for package test
jberkel d238192
Specify traits for Android
jberkel 8803370
Fix version
jberkel 45b1379
18.4 no longer available
jberkel 6a3eb30
Test flag not needed
jberkel 68edecd
Print available simulators
jberkel 1af0c64
Document traits
jberkel ae132d1
Update pod repo
jberkel 5ae282e
The CI pulls an old version of SQLCipher
jberkel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use caution with relying on default enabledTraits. Xcode UI still hasn't caught up and doesn't respect the default enabled traits. All the swift command line commands work properly with it, but for direct Xcode integrators it won't work. I'd recommend leaving the desired default as "trait-less" so that it works out of the box when adding the package in the Xcode UI.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yes I'm hesitant about this. Right now it should be OK because the defines in the code don't check explicitly for this:
But if it's not needed maybe it's safer to leave this out (for now, until Xcode catches up)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, excellent. That looks good to me. I should have looked closer at the rest of the commit for the adjusted import conditional prior to commenting.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this is unrelated, but thought I'd mention it to you:
Since I started using the package with the SQLCipher changes (without using the trait),I keep seeing the warning
in the logs during package resolve (just a warning, it seems).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that integrating into an Xcode project using the Xcode interface to add the package, calling
swift package resolvefrom within theSQLite.swiftfolder, or consuming it as referenced from anotherPackage.swift?If it's using the Xcode interface, which version of Xcode are you using?
I tried using Xcode 26.2 consuming the package on the
simplify-traitbranch both from a local checkout and referencing it from the GitHub url, but didn't see that warning in Resolve Packages.I wonder if resetting the package caches in Xcode would help at all via File > Packages > Reset Package Caches if you haven't tried that yet?
Running
swift package resolve --very-verbosefrom the SQLite.swift checkoutsimplify-traitbranch didn't produce the warning for me either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was from within Xcode (16.4), when updating packages. I've tried to reproduce it, but it's gone now, probably just some temporary thing. If it turns up again I'll let you know.