refactor: remove #[cfg(test)] type aliases for old config types#133
Open
stephenleo wants to merge 3 commits intostory-3-1-v2from
Open
refactor: remove #[cfg(test)] type aliases for old config types#133stephenleo wants to merge 3 commits intostory-3-1-v2from
stephenleo wants to merge 3 commits intostory-3-1-v2from
Conversation
… and ContextWindowSubfieldConfig Replace all test usages with SubfieldConfig directly so test code honestly reflects the real type and future type divergence is not masked by silent-compiling aliases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove the dead `impl_has_threshold_style!` macro (defined but never invoked) from config.rs and relocate the `#[cfg(test)] use SubfieldConfig` import in cost.rs from file-top to inside the test module where it belongs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[cfg(test)]type aliasesCostSubfieldConfigandContextWindowSubfieldConfigfromsrc/config.rs.impl_has_threshold_style!macro.SubfieldConfigdirectly.Re-submission of PR #128 after revert. Depends on PR #132.
Test plan
cargo buildexits 0 with no errorscargo testpasses all tests with no regressionscargo clippy -- -D warningsexits 0 (no new warnings introduced)CostSubfieldConfigandContextWindowSubfieldConfigtype aliases are fully removed🤖 Generated with Claude Code