Fixes non-focused menu item when navigating to a deep destination.#318
Open
sydneyhauke wants to merge 11 commits into
Open
Fixes non-focused menu item when navigating to a deep destination.#318sydneyhauke wants to merge 11 commits into
sydneyhauke wants to merge 11 commits into
Conversation
sydneyhauke
requested review from
lgraziano and
nkalten
and removed request for
lgraziano
June 4, 2021 17:31
…d-team/app into bug-fix/nav-selector-looses-focus
theo-damiani
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue : #192
Now, when we navigate into deep fragment destination and come back and try to open the menu drawer, the corresponding menu item is still focused as it should be.