An unhandled exception may occur when expected buttons mismatch the actually reported ones#23
Open
Artyom17 wants to merge 1 commit intostewdio:masterfrom
Open
An unhandled exception may occur when expected buttons mismatch the actually reported ones#23Artyom17 wants to merge 1 commit intostewdio:masterfrom
Artyom17 wants to merge 1 commit intostewdio:masterfrom
Conversation
…xpected buttons/axes is greater than the actual buttons / axes reported by the browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just recently hit that issue: different browsers may report different number of buttons (and theoretically - axes) for the same controllers (even though the order of those, obviously, must be correct). If the number of expected buttons is greater than the number of buttons actually reported then VRController throws an exception (in line 187).
For safety reasons I am adding if check for buttons and axes.