Skip to content

fix negation not being parsed after a comma #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfmengels merged 1 commit into from
Feb 12, 2025
Merged

fix negation not being parsed after a comma #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Elm/Parser/Expression.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,6 +941,9 @@ negationOperation =
"}" ->
negationAfterMinus

"," ->
negationAfterMinus

-- TODO only for tests
"" ->
negationAfterMinus
Expand Down
17 changes: 17 additions & 0 deletions tests/Elm/Parser/ExpressionTests.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,23 @@ all =
(Node { start = { row = 1, column = 1 }, end = { row = 1, column = 3 } }
(Negation (Node { start = { row = 1, column = 2 }, end = { row = 1, column = 3 } } (FunctionOrValue [] "x")))
)
, test "negated expression after comma" <|
\() ->
"(0,-x)"
|> expectAst
(Node { start = { row = 1, column = 1 }, end = { row = 1, column = 7 } }
(TupledExpression
[ Node { start = { row = 1, column = 2 }, end = { row = 1, column = 3 } }
(Integer 0)
, Node { start = { row = 1, column = 4 }, end = { row = 1, column = 6 } }
(Negation
(Node { start = { row = 1, column = 5 }, end = { row = 1, column = 6 } }
(FunctionOrValue [] "x")
)
)
]
)
)
, test "negated expression in application" <|
\() ->
"toFloat -5"
Expand Down