Skip unicode table lookups for ASCII characters in Char.Extra#278
Merged
jfmengels merged 1 commit intostil4m:masterfrom Apr 3, 2026
Merged
Conversation
performance boost.
Collaborator
|
Amazing! Thank you very much. |
Contributor
|
Good catch! I can probably port back some of this to elm-unicode 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short-circuit ASCII characters so common terminators like parens, commas, and braces perform 5 checks instead of 10+ checks. Also moves
String.fromCharallocation insideunicodeIsLowerFast/unicodeIsUpperFastto reduce GC work.Benchmarked at 10-26% faster parsing on real-world Elm files.