Skip to content

Changed the ApiExceptionSubscriber to be less aggressive#18

Merged
stixx merged 1 commit intomainfrom
exception-subscriber-priority
Mar 2, 2026
Merged

Changed the ApiExceptionSubscriber to be less aggressive#18
stixx merged 1 commit intomainfrom
exception-subscriber-priority

Conversation

@stixx
Copy link
Owner

@stixx stixx commented Mar 2, 2026

This pull-request resolves issues where the subscriber was too aggressive causing the AccessDeniedException to be intercepted.

Summary by CodeRabbit

  • Chores
    • Adjusted exception handler execution timing in the event processing queue to improve handling order consistency.

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 391eda8 and 9cb539b.

📒 Files selected for processing (1)
  • src/EventSubscriber/ApiExceptionSubscriber.php

Walkthrough

The event subscriber's KernelEvents::EXCEPTION handler priority was reduced from 256 to -10, causing the exception subscriber to execute later in the event processing sequence, after listeners with higher priority values.

Changes

Cohort / File(s) Summary
Exception Handler Priority Adjustment
src/EventSubscriber/ApiExceptionSubscriber.php
Changed KernelEvents::EXCEPTION listener priority from 256 to -10, lowering execution order in the event processing pipeline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A whisker twitch, a number swayed,
From 256 down the path we've made,
To -10 where exceptions rest,
Later in the queue's grand quest! 🎪

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Changed the ApiExceptionSubscriber to be less aggressive' accurately describes the main change: lowering event listener priority from 256 to -10, which reduces the subscriber's execution priority and makes it less aggressive in exception handling.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch exception-subscriber-priority

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@stixx stixx added the bug Something isn't working label Mar 2, 2026
@stixx stixx merged commit b29b3ac into main Mar 2, 2026
3 checks passed
@stixx stixx deleted the exception-subscriber-priority branch March 2, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant