Tx: make abort() function public.#52
Open
projectgus wants to merge 1 commit intostm32-rs:masterfrom
Open
Conversation
Equivalent function in FdCan<I, M> is already public.
Author
|
I'm going out on a limb here, but alternative way to look at this, maybe, is that
... and it's not really needed for anything else. So an alternative breaking change could be:
This would be a breaking change though, and quite opinionated change for a newcomer like me to suggest. I'd be up for contributing this though, FWIW. 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows access to abort function after splitting the driver. The equivalent function in
FdCan<I, M>is already public, so I think this is safe.Thanks for all your work developing fdcan, it's much appreciated!