Skip to content

chore: update PR guidance files (2026-04-20) - #270

Merged
coleenquadros merged 2 commits into
release-5.0from
chore/update-pr-guidance-2026-04-20
Apr 20, 2026
Merged

chore: update PR guidance files (2026-04-20)#270
coleenquadros merged 2 commits into
release-5.0from
chore/update-pr-guidance-2026-04-20

Conversation

@coleenquadros

Copy link
Copy Markdown

Summary

Updates .cve-fix/examples.md with new patterns observed since the last analysis (2026-04-16).

What Changed

CVE Guidance (.cve-fix/examples.md)

  • New rule: Alternate title format fix(cve): CVE-YYYY-XXXXX - package (used by CVE Fixer workflow)
  • New rule: npm/JS ecosystem file co-changes — web/ui/package.json, web/ui/package-lock.json, web/ui/embed.go, and web/ui/static/**/*.gz for npm CVEs
  • New rule: npm override strategy — use overrides.<package> in package.json for transitive deps
  • Updated: PR Description guidance expanded with impact, vulnerable version range, fixed version, Jira Resolves: ACM-XXXXX format, and bot attribution markers
  • Updated: last-analyzed date to 2026-04-20

New PRs Analyzed

⚠️ Limited data: No new merged CVE PRs since last analysis. Additions are based on 1 open PR + commit fallback — verify patterns before relying on them.


Generated by PR Guidance Generator workflow

Refreshed .cve-fix/examples.md with patterns from PRs/commits since 2026-04-16.

Changes:
- Added alternate title format: fix(cve): CVE-YYYY-XXXXX - package
- Added npm/JS ecosystem file co-change rules (web/ui/package.json, package-lock.json, embed.go, static/*.gz)
- Added npm override strategy for transitive dep CVEs
- Expanded PR description guidance (impact, vuln range, fixed version, Resolves: ACM-XXXXX, bot markers)
- Updated last-analyzed date to 2026-04-20
- Added limited-data warning (0 new merges since last analysis)

Co-Authored-By: PR Guidance Generator <noreply@anthropic.com>
Document the required build sequence for npm/JS CVE fixes in web/ui:
  1. npm install (resolves override)
  2. build_ui.sh --all (rebuilds React app)
  3. compress_assets.sh (regenerates .gz files + embed.go)

These steps produce ~66 changed asset files and must be run in order.

Co-Authored-By: PR Guidance Generator <noreply@anthropic.com>
@coleenquadros

Copy link
Copy Markdown
Author

/lgtm

@openshift-ci

openshift-ci Bot commented Apr 20, 2026

Copy link
Copy Markdown

@coleenquadros: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Apr 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coleenquadros
coleenquadros merged commit 5367cfa into release-5.0 Apr 20, 2026
6 of 8 checks passed
@coleenquadros
coleenquadros deleted the chore/update-pr-guidance-2026-04-20 branch April 20, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant