Skip to content

[release-2.16] Fix CVE-2026-42154: validate snappy decoded length in remote read - #360

Open
katekeiroz-dev wants to merge 2 commits into
stolostron:release-2.16from
katekeiroz-dev:fix-cve-2026-42154-release-2.16
Open

[release-2.16] Fix CVE-2026-42154: validate snappy decoded length in remote read#360
katekeiroz-dev wants to merge 2 commits into
stolostron:release-2.16from
katekeiroz-dev:fix-cve-2026-42154-release-2.16

Conversation

@katekeiroz-dev

@katekeiroz-dev katekeiroz-dev commented Jul 14, 2026

Copy link
Copy Markdown

Summary

  • Cherry-pick of 497f8989b from release-2.17
  • Validates snappy decoded length before allocation in the remote read endpoint (/api/v1/read)
  • Prevents unauthenticated DoS via crafted snappy payload (snappy bomb)

CVE

  • CVE-2026-42154 (CVSS 7.5 HIGH) — Unauthenticated Denial of Service via Snappy Bomb in Prometheus Remote Read Endpoint

Jira

ACM-35487

Test plan

  • Cherry-pick applies cleanly
  • Includes test TestDecodeReadRequestTooLarge
  • CI passes

…oint

Fix CVE-2026-42154

Cherry-pick of 497f898 from release-2.17

Jira:
ACM-35487 - https://redhat.atlassian.net/browse/ACM-35487

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Kate Barreiros <kbarreir@redhat.com>
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: katekeiroz-dev
Once this PR has been reviewed and has the lgtm label, please assign moadz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@katekeiroz-dev

Copy link
Copy Markdown
Author

/test

@katekeiroz-dev

Copy link
Copy Markdown
Author

/test all

@katekeiroz-dev

Copy link
Copy Markdown
Author

/retest

- Bump golang-builder images from 1.24-base to 1.25-base
- Bump test_go_oldest from 1.23-base to 1.25-base (go.mod minimum)
- Update setup-go from 1.24.x to 1.25.x (Windows, parser, golangci)
- Upgrade golangci-lint from v2.1.5 to v2.4.0 (Go 1.25 support)
- Fix .tekton YAML indentation (pipelineRef.params 6→4 spaces)

Signed-off-by: Kate Barreiros <kbarreir@redhat.com>
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants