Skip to content

[release-2.11] Fix CVE-2026-42154: validate snappy decoded length in remote read - #363

Open
katekeiroz-dev wants to merge 1 commit into
stolostron:release-2.11from
katekeiroz-dev:fix-cve-2026-42154-release-2.11
Open

[release-2.11] Fix CVE-2026-42154: validate snappy decoded length in remote read#363
katekeiroz-dev wants to merge 1 commit into
stolostron:release-2.11from
katekeiroz-dev:fix-cve-2026-42154-release-2.11

Conversation

@katekeiroz-dev

@katekeiroz-dev katekeiroz-dev commented Jul 14, 2026

Copy link
Copy Markdown

Summary

  • Cherry-pick of 497f8989b from release-2.17 (conflict resolved in codec_test.go)
  • Validates snappy decoded length before allocation in the remote read endpoint (/api/v1/read)
  • Prevents unauthenticated DoS via crafted snappy payload (snappy bomb)

CVE

  • CVE-2026-42154 (CVSS 7.5 HIGH) — Unauthenticated Denial of Service via Snappy Bomb in Prometheus Remote Read Endpoint

Jira

ACM-35419

Test plan

  • Cherry-pick applied (minor conflict resolved in test file)
  • Includes test TestDecodeReadRequestTooLarge
  • CI passes

…oint

Fix CVE-2026-42154

Cherry-pick of 497f898 from release-2.17

Jira:
ACM-35419 - https://redhat.atlassian.net/browse/ACM-35419

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Kate Barreiros <kbarreir@redhat.com>
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: katekeiroz-dev
Once this PR has been reviewed and has the lgtm label, please assign coleenquadros for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

@katekeiroz-dev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/common-test 3411076 link true /test common-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants