Fix build with CMake 4#45
Open
panchoh wants to merge 1 commit intostolowski:masterfrom
Open
Conversation
Bump minimum required version of CMake to 3.10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
CMake 4, released half a year ago, has dropped compatibility with versions older than 3.5.
This patch bumps the minimal required version of CMake to 3.10 (note: I’ve also tested it with a value of 4.1.2, the latest available CMake release, and it builds ok as well without changes).
I've set it to 3.10 as a middle ground, so it doesn’t get deprecated as soon as 3.5 will be, and yet doesn’t impose a too new CMake release to build (if you are running Debian 13, for example).
This issue has come up recently on nixpkgs, where a migration to CMake 4 is underway. See NixOS/nixpkgs/issues/445447 for reference.
Hope that it helps, and congrats for the project!