enable kobuki Windows build#87
Open
kejxu wants to merge 1 commit intostonier:release/0.62-melodicfrom
Open
Conversation
* windows bringup * local update * remove windows.h dependency * revert unnecessary change * remove unnecessary change * complete TimeStamp::stamp implementation on Windows * revert code cleanup changes * revert code cleanup * revert code cleanup * remove data type collision * update ecl::Thread to use std::thread * remove unused stack_size argument * remove code cleanup * remove c++14-only make_unique * remove commented out code * fix brace style mismatch * use same type for inheritence * make numeric_limits header-only * add back lib subfolder for proper linking * complete detect_sizes
Author
|
@stonier Thanks for being responsive! I have created https://github.com/ms-iot/ROSOnWindows/projects/20?add_cards_query=is%3Aopen to track all the changes related to the current porting work for Windows build is verified in this cloud build: https://dev.azure.com/kejxu/ROS%20on%20Windows/_build/results?buildId=138&view=results Ubuntu build was verified manually on a 18.04 vm (Azure Devops does not have hosted 1804 vms yet) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update ecl_core to enable the kobuki code base to build on Windows. changes in this pr:
ERROR, etc.)__stdcallcould be used; function pointers should not be explicitly casted since they contain calling convention)dllimportmacronumeric_limits.cppto header file. this is a bit complicated but the reason behind this is becausedllimportshould not be added to a class derived from a STL class. In order to achieve that, definitions in .cppneed to be moved into.h. Withconstexpradded in c++11, this is now feasiblethis port points to the melodic release branch because it currently only targets ROS1.melodic