fix: prevent listener accumulation via shared onceExclusive() base class#68
Merged
Merged
Conversation
Introduce NobleEventEmitter, a thin EventEmitter subclass with a single onceExclusive(event, callback) method that ensures at most one listener per event name. Previous listener is removed before adding a new one, preventing accumulation when methods are called repeatedly before the event fires. All classes (Noble, Peripheral, Characteristic, Service, Descriptor) now extend NobleEventEmitter and use onceExclusive() for callback-based methods: setScanParameters, startScanning, stopScanning, connect, disconnect, updateRssi, discoverServices, read/writeHandle, write, subscribe/unsubscribe, discoverDescriptors, broadcast, readValue, writeValue, discoverIncludedServices, discoverCharacteristics. Also fixes cross-listener cleanup in discoverAsync() and notificationsAsync() using a shared cleanup guard pattern. Closes #61 https://claude.ai/code/session_013EXDtBm4WGje3Jcbt4LBP9
|
🎉 This PR is included in version 2.3.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce NobleEventEmitter, a thin EventEmitter subclass with a single onceExclusive(event, callback) method that ensures at most one listener per event name. Previous listener is removed before adding a new one, preventing accumulation when methods are called repeatedly before the event fires.
All classes (Noble, Peripheral, Characteristic, Service, Descriptor) now extend NobleEventEmitter and use onceExclusive() for callback-based methods: setScanParameters, startScanning, stopScanning, connect, disconnect, updateRssi, discoverServices, read/writeHandle, write, subscribe/unsubscribe, discoverDescriptors, broadcast, readValue, writeValue, discoverIncludedServices, discoverCharacteristics.
Also fixes cross-listener cleanup in discoverAsync() and notificationsAsync() using a shared cleanup guard pattern.
Closes #61
https://claude.ai/code/session_013EXDtBm4WGje3Jcbt4LBP9