Add ability to set custom MTU via connect options#75
Merged
Conversation
Allow users to specify a desired MTU per-connection by passing an `mtu`
option to `peripheral.connect({ mtu: 512 })`. Defaults to 256 if not
specified, preserving existing behavior.
Closes #71
https://claude.ai/code/session_014RCJBatLRdZ3pqdSFaAgkv
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
peripheral.connect({ mtu: 512 }), resolving the hardcoded 256-byte limitUsage
Changes
lib/hci-socket/gatt.js: Accept optionaldesiredMtuparameter inGattconstructor, used as_desired_mtu(falls back to 256)lib/hci-socket/bindings.js: Extractmtufrom connection parameters and pass it to theGattconstructorTest plan
mtuoption — should negotiate MTU of 256 (unchanged behavior){ mtu: 512 }— should negotiate up to 512 with the remote deviceperipheral.mtureflects the negotiated value after connectionCloses #71
https://claude.ai/code/session_014RCJBatLRdZ3pqdSFaAgkv