feat: add spec to describe space/content/decrypt ability#132
Open
BravoNatalie wants to merge 3 commits intomainfrom
Open
feat: add spec to describe space/content/decrypt ability#132BravoNatalie wants to merge 3 commits intomainfrom
BravoNatalie wants to merge 3 commits intomainfrom
Conversation
19beb03 to
dbc8342
Compare
27a79be to
411afd0
Compare
411afd0 to
b82993e
Compare
hannahhoward
approved these changes
Mar 13, 2025
Member
hannahhoward
left a comment
There was a problem hiding this comment.
This is awesome, LGTM. Recommend removing references to "decentralized" for the key management system -- it's not a requirement, more a recommendation (and we use a decentralized KMS for our implementation)
|
|
||
| The encryption service performs the role of managing keys in a decentralized context. It enables encryption and provides a way to validate invocations to decrypt content. The service should implemented a secure encryption system (e.g., Lit Protocol) that supports: | ||
|
|
||
| 1. Multi-party threshold secret sharing (TSS) to enable decentralized public key cryptography |
Member
There was a problem hiding this comment.
technically we can drop the first two.
Member
There was a problem hiding this comment.
a centralized system is fine
| The encryption service MUST: | ||
|
|
||
| 1. Support identity-based encryption with access control conditions | ||
| 2. Provide secure decentralized key management |
Member
There was a problem hiding this comment.
does not require "decentralized"
This was referenced Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the objectives outlined in the issue #130
Please refer to the issue for a detailed context.