test(upload-client): allow large byte uploads#1532
Open
StefanoDeVuono wants to merge 1 commit intostoracha:mainfrom
Open
test(upload-client): allow large byte uploads#1532StefanoDeVuono wants to merge 1 commit intostoracha:mainfrom
StefanoDeVuono wants to merge 1 commit intostoracha:mainfrom
Conversation
There was an issue with large byte uploads in tests. This commit fixes the issue by first converting bytes to UnixFS stream before making CAR object in packages/upload-client/test/helpers/car.js
StefanoDeVuono
force-pushed
the
chore/fix-car-cid-in-test
branch
from
572cd3a to
0a554cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue with large byte uploads in tests highlighted in issue 1518
This commit fixes the issue by first converting bytes to UnixFS stream before making CAR object in
packages/upload-client/test/helpers/car.js.Included is a video of the tests passing with both the current byte size (128) and the previously failing byte size (2_000_0000):
test.mp4