Conversation
| COPY --from=binaries /var/lib/storj/go/bin /var/lib/storj/go/bin | ||
| COPY --from=binaries /var/lib/storj/storj/web/satellite/stati[c] /var/lib/storj/storj/web/satellite/static | ||
| COPY --from=binaries /var/lib/storj/storj/web/satellite/dis[t] /var/lib/storj/storj/web/satellite/dist | ||
| COPY --from=binaries /var/lib/storj/storj/web/satellite/dist_vuetify_poc /var/lib/storj/storj/web/satellite/dist_vuetify_poc |
There was a problem hiding this comment.
The brackets are needed here because if you pass in the build arg SKIP_FRONTEND_BUILD=true (which is useful to speed up the build in cases where you just want to test with the satellite and uplink, and don't need the front end build) you will get an error "/var/lib/storj/storj/web/satellite/dist_vuetify_poc": not found. If you add a bracket around the last character to make this line COPY --from=binaries /var/lib/storj/storj/web/satellite/dist_vuetify_po[c] /var/lib/storj/storj/web/satellite/dist_vuetify_poc this tells docker "I only want to copy this folder if it exists. If it doesn't exist, it's not an error, just continue."
There was a problem hiding this comment.
Don't we have the same issue with some lines further down? The admin UI is missing the brackets.
Still requires
storj-up env setenv satellite-api STORJ_CONSOLE_USE_VUETIFY_PROJECT=trueI didn't include that into the PR because it makes more sense to just switch it on by default in the storj repository.