Open
Conversation
…nal for scheduler parameter
…nclude IntervalForward in tests
…related components and added tests - Updated AddUncertainty transformer to handle RationalNumber types, allowing for exact arithmetic with RationalInterval. - Modified various helper functions and model checkers to accommodate RationalNumber and RationalInterval. - Introduced new tests for RationalNumber scenarios in model checking and uncertainty transformations. - Ensured compatibility with existing models while expanding functionality for uncertain models using RationalNumber.
Contributor
|
This includes #832, which should thus be reviewed/merged first? |
…parameters and update tests accordingly
… uncertainty parameter
sjunges
reviewed
Mar 20, 2026
src/storm/modelchecker/results/ExplicitQualitativeCheckResult.cpp
Outdated
Show resolved
Hide resolved
sjunges
reviewed
Mar 20, 2026
sjunges
reviewed
Mar 20, 2026
sjunges
reviewed
Mar 20, 2026
sjunges
reviewed
Mar 20, 2026
sjunges
reviewed
Mar 20, 2026
sjunges
reviewed
Mar 20, 2026
Contributor
|
Great work! I have not checked the new finite-horizon model checking algorithm (yet). Also, have you checked that we didnt miss (or recently introduce) an instance of std::is_same_v<ValueType, storm::Interval>? I also noted that we are not always consistently using constexpr in front of that, but that is maybe also not so important :) |
… error messages about intervals in SparseMdpPrctlHelper.
…optimization direction in ViOperatorMultiplier
Contributor
Author
|
Bounded reachability for interval models was only implemented for robust optimization. I am now adding the uncertainty optimization direction to the multiplier in order to support all uncertainty optimization directions. This was also the reason of the weird minimization when maximizing. |
Contributor
Author
|
All checks are passing. This is ready for a final review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add exact Intervals and bounded model checking of intervals