Conversation
| set(STORM_RESOURCE_LIBRARY_INSTALL_DIR "${_IMPORT_PREFIX}/@STORM_RESOURCE_LIBRARY_INSTALL_DIR@") | ||
|
|
||
| include("${CMAKE_CURRENT_LIST_DIR}/carlConfig.cmake") | ||
| include("${STORM_RESOURCE_LIBRARY_INSTALL_DIR}/cmake/carl/carlConfig.cmake") |
There was a problem hiding this comment.
I am not sure about replacing ${CMAKE_CURRENT_LIST_DIR} by ${STORM_RESOURCE_LIBRARY_INSTALL_DIR}/cmake What is the motivation for that (I understand the carl/ part?
There was a problem hiding this comment.
With the new changes, the carlConfig will be in a directory next to the Storm repository and not a sub-directory anymore. So we would need to go up one directory. But I guess we could still use "${CMAKE_CURRENT_LIST_DIR}/../carl/carlConfig.cmake".
There was a problem hiding this comment.
Ok, so I dislike a bit that carl will be installed on the same level as storm, but if we do it that way, I understand the use of absolute paths.
There was a problem hiding this comment.
Ok, then I will keeps it as is for now.
I will check whether putting carl a level deeper would also work.
| set(STORM_RESOURCE_LIBRARY_INSTALL_DIR lib/storm/resources/ CACHE PATH "Installation directory for dependency library files") | ||
| include(GNUInstallDirs) | ||
| set(STORM_INCLUDE_INSTALL_DIR ${CMAKE_INSTALL_INCLUDEDIR}/storm CACHE PATH "Installation directory for header files" ) | ||
| set(STORM_LIB_INSTALL_DIR ${CMAKE_INSTALL_LIBDIR} CACHE PATH "Installation directory for libraries") |
There was a problem hiding this comment.
Why change the default? For custom-built paths (vs packages) the old default seems to make it easier to cleanup?
There was a problem hiding this comment.
The CMake variables CMAKE_INSTALL_INCUDEDIR etc. can also be set from cmake or ccmake. So this makes it a bit more configurable in my view instead of using fixed paths as default. I thought using the standard locations provided by GnuInstallDirs would make it better align with the standard behavior of others.
2 participants
CMAKE_INSTALL_LIBDIRinstead ofliblibcarlinto the same directory as the Storm libs to avoid issues with subdirectories