Sco 2704 create an api endpoint to return available stories for each - #175
Merged
timosville merged 8 commits intoJul 23, 2026
Conversation
…aging localized stories
timosville
marked this pull request as ready for review
July 22, 2026 12:32
Deploying kit with
|
| Latest commit: |
d6cb621
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e9b3919e.kit-atq.pages.dev |
| Branch Preview URL: | https://sco-2704-create-an-api-endpo.kit-atq.pages.dev |
| const { app } = await service.storiesByLocale(); | ||
|
|
||
| assert.deepEqual(app, [ | ||
| { locale: 'en', name: 'English', nativeName: 'English' }, |
Contributor
There was a problem hiding this comment.
@timosville @JannieT in the app locale list we will also need a isRTL field as well.
… related parsing and tests
JannieT
approved these changes
Jul 23, 2026
JannieT
left a comment
JannieT
left a comment
Member
There was a problem hiding this comment.
Please merge when you have refactored the suggested name changes
| stories: StoryIndexItem[]; | ||
| } | ||
|
|
||
| export interface LocaleStoriesItem { |
Member
There was a problem hiding this comment.
There might be other content types in the future:
Suggested change
| export interface LocaleStoriesItem { | |
| export interface LocaleContentItem { |
| export class LocaleService { | ||
| public constructor(protected readonly config: CmsConfig) {} | ||
|
|
||
| public async storiesByLocale(): Promise<LocaleStoriesResponse> { |
Member
There was a problem hiding this comment.
Suggested change
| public async storiesByLocale(): Promise<LocaleStoriesResponse> { | |
| public async localeIndex(): Promise<LocaleIndexResponse> { |
| nativeName: string; | ||
| } | ||
|
|
||
| export interface LocaleStoriesResponse { |
Member
There was a problem hiding this comment.
This is a response describing the locale setup and stories is just a part of the content and configuration it reports on:
Suggested change
| export interface LocaleStoriesResponse { | |
| export interface LocaleIndexResponse { |
timosville
deleted the
sco-2704-create-an-api-endpoint-to-return-available-stories-for-each
branch
July 23, 2026 10:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.