test(robolectric): Phase 1 remainder + Phase 2 worker/notification gates#81
Merged
Conversation
Ship remaining Tier 1 Robolectric tests (DataStore, import, notifications channel), add guard-only BoomerangRenderWorker and POST_NOTIFICATIONS gate coverage on the JVM, and extract pure permission decision helpers from MainActivity for API 32 vs 33+ testing. Co-authored-by: Cursor <cursoragent@cursor.com>
Add a scannable inventory of all Phase 1–2 JVM framework tests with run commands, method lists, and device complements; link it from guides README, TEST_COVERAGE, OEM regression guide, and the existing Robolectric tutorial. Co-authored-by: Cursor <cursoragent@cursor.com>
Retire docs/active, completed, diagnostics, and android-16 — shipped work lives in git history, lessons_learned/, and guides/. Add layout rules, CI doc-layout gate, and fix all surviving cross-references. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserPreferencesRepositoryImplRobolectricTest), import copy contract (VideoImporterImportRobolectricTest), and notification channel/progress/immutability (BoomerangRenderNotificationsRobolectricTest).BoomerangRenderWorkerRobolectricTest): invalid input →Result.failure(), validgetForegroundInfo(), FGS promotion denied → failure + partial-output cleanup — never reachesVideoProcessor.renderBoomerang. Addswork-testingtotestImplementation.shouldRequestPostNotificationsPermission/shouldShowNotificationExportHintfromMainActivityand cover API 32 no-op vs API 33+ gate inPostNotificationsGateRobolectricTest.docs/guides/robolectric-testing-explained.mdanddocs/TEST_COVERAGE.md. Phase 3 (Robolectric Compose) evaluated and deferred — no harness yet.Test plan
./gradlew :app:testDebugUnitTest— 0 failures (full suite)./gradlew :app:lintDebug— 0 new lint errors (baseline policy)POST_NOTIFICATIONS→ save loop → permission prompt appears; Processing screen shows background-export hint when deniedNot verified
Made with Cursor