chore(crashlytics-autotriage): local-test deps, ignore secrets, runbook#86
Merged
Merged
Conversation
Follow-ups from the Phase 0 local end-to-end test: - functions/package.json: add firebase-admin (required by functions:shell / emulator) - .gitignore: ignore functions/.secret.local and *.secret.local (local shell secret) - docs/FIREBASE.md: add "Testing locally — fake a crash end-to-end" section with the functions:shell steps and gotchas (payload shape, ASCII-only, dedupe 422)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-ups captured while running the Phase 0 local end-to-end test of the Crashlytics auto-triage system (the
firebase functions:shell"fake crash" path).functions/package.json— addfirebase-admin(the Functions emulator /functions:shellrefuses to load functions without it)..gitignore— ignorefunctions/.secret.localand*.secret.local(the local-only token file the shell reads). Keeps the GitHub PAT out of git.docs/FIREBASE.md— add a "Testing locally — fake a crash end-to-end" section documenting thefunctions:shellsteps and the gotchas we hit (payload must be{payload:{issue:{…}}}with nodata:wrapper, plain-ASCII only,firebase-adminrequirement, dedupe422). Also corrected thesecrets:accesscomment (it does print the value).Related Issue
Follows #83 (initial scaffold).
Type of Change
How Has This Been Tested?
firebase functions:shelllocally and invokedcrashlyticsToGithub({payload:{issue:{…}}})— it created a real GitHub issue (confirming function → issue → workflow trigger). Steps reproduced in the newFIREBASE.mdsection.Note / known follow-up
The workflow's triage step isn't completing yet (test issues got created but Claude posted no comment) — being diagnosed separately from the Actions logs; not part of this PR.
Checklist
.secret.localare gitignored).