Create GC optional flag; Fix for running on Windows#5
Open
jimmarino wants to merge 13 commits into
Open
Conversation
jeffvroom
reviewed
Feb 8, 2017
Member
jeffvroom
left a comment
jeffvroom
left a comment
There was a problem hiding this comment.
There were some conflicts in these changes and I wanted to make a couple of tweaks to what's here anyway so I just applied the changes by hand and updated stratacode:master rather than merging.
For makePathAbsolute, let's just pass in a path with the path_separator_char. That will require a tweak on your end to how you call it.
Also, the option name was misspelled - disableCG -> disableGC. Once you make those two changes on your end, we should be sync'd up and we can close this out without merging. Sound OK?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jeff,
It looks like I can't separate out the individual commits easily but the number of changes are small so it should be OK. Note the getBoundsType was something I needed to access the type information so I added that too.