Match Bitcoin Core v31 breaking changes, add SRI integration test#65
Draft
Sjors wants to merge 4 commits intostratum-mining:masterfrom
Draft
Match Bitcoin Core v31 breaking changes, add SRI integration test#65Sjors wants to merge 4 commits intostratum-mining:masterfrom
Sjors wants to merge 4 commits intostratum-mining:masterfrom
Conversation
Collaborator
Author
|
Note to self: bump the minor release version for this breaking change |
Sjors
changed the title
Collaborator
Author
|
I'll update this with the other v31 breaking changes once bitcoin/bitcoin#34568 is merged. |
Align sv2-tp's IPC interface definitions with Bitcoin Core v31. Move Init::makeMining to ordinal 3, leave ordinal 2 as an internal assertion trap, add the createNewBlock context and cooldown arguments plus the interrupt method, and remove the old BlockTemplate coinbase accessors. Switch sv2-tp to the CoinbaseTx-only path. Dropping the signet witness-commitment check is safe because Bitcoin Core populates required_outputs only after GenerateCoinbaseCommitment() has added the witness commitment when needed. Also document that v1.0.6 is the last release compatible with Bitcoin Core v30.2. Assisted-by: OpenAI GPT-5-Codex
Call Mining::interrupt() during Template Provider shutdown so createNewBlock() and waitTipChanged() can exit promptly when Bitcoin Core's cooldown path is blocking. This complements BlockTemplate::interruptWait(), which only covers waits on already-created templates. Assisted-by: OpenAI GPT-5-Codex
Only document a regtest setup using the native sv2 CPU miner. Leave more complicated setups, like an ASIC on testnet4, to the SRI docs.
Collaborator
Author
|
Updated to include the full set of breaking changes for 31.x. I also updated the testing guide, in particular to reflect that sv2-apps has a working sv2 native CPU miner, which makes it a lot easier. |
Collaborator
Author
|
I turned the |
Sjors
changed the title
14 tasks
Sjors
force-pushed
the
2025/11/context
branch
3 times, most recently
from
97f2a47 to
3592101
Compare
Add a GitHub Actions job that downloads Bitcoin Core v31.0rc1, builds sv2-tp plus the pool and miner binaries from sv2-apps main, and runs the documented regtest scenario. Use actions-rust-lang/setup-rust-toolchain to match the existing bitcoin-capnp-types project lead. Assisted-by: OpenAI GPT-5 Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be done after:
This is a breaking change. Documentation is updated to explain how to use it (once the Bitcoin Core PR is merged).